Skip to content

Distinguish signed replan captures from staged reads in CLI tests - #9181

Merged
loopx-agent merged 1 commit into
mainfrom
codex/replan-staged-capture-contract-20261121
Nov 21, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/replan-staged-capture-contract-20261121

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Summary

The Codex App declaration now returns a complete, signed Turn decision with or without the explicit --turn-envelope flag. The staged-read test expected that opening to have already deferred its settlement plan, so all four File and SQLite cases stopped before the reader and writeback checks.

Verify the signed decision against the saved capture, then obtain the staged view from the existing projection and execute its review and writeback commands against that same capture. The test checks the original settlement identity, the pinned executable, digest and content integrity refusal, digest propagation to the next read, and acceptance of the original Turn's semantic writeback.

Validation

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent · gpt-6.2-sol · OpenAI (runtime_reported, xhigh)

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

动机 / Motivation

File 和 SQLite 的四条实 CLI 用例在基线将完整签名决策当成分段视图,因而在回读和写回前失败。该合同要求保存完整决策,并从同一捕获读取重规划事实和原结算步骤。 协议

维护 Codex App 重规划读回的开发者依赖这组真实 CLI 用例。 目标基线的四组用例都在收缩断言处失败,候选继续走到原件读回与写回。 回读恢复同一份捕获的规划事实和结算计划,原 Turn 的语义写回得到接受。 这次验证使用本地 File 和 SQLite 的合成 Goal,捕获显式关闭渐进交付。 正式安装 Host、启用渐进交付的路径及托管检查留待各自验收。

改动思路 / Approach

在现有集成用例里分别验证 CLI 决策与原件的绑定,再用现有投影生成分段视图。读取阶段使用输出中的可执行命令,缺失的 registry 和优先出现在 PATH 的替身均未改变回读路径。

具体改动 / Changes

审查候选 1bd566c369a54cb7ad5f3b349cc2bdbf914f97e8。GitHub 目标 85efe20f07c366478bd8911fa6f9f12d4ad54dc2 已前进一笔,实际比较起点为 d400a9cbab20f277f4a01deb394c6dad8d1b7c0f,提案范围是一份测试文件,新增 38 行、移除 23 行。

  • capture-binding 两种 Codex App 声明均检查完整回执。分段视图保留原 settlement identity,写回读取恢复原结算计划。 绑定与视图
  • integrity 修改 Goal、Agent、Turn 或决策正文后,显式摘要读均拒绝该原件。省略显式摘要时,正文变更仍被签名内容校验拒绝。恢复原件后,下一条写回读取带上原摘要。 负例与恢复
  • same-turn-writeback 回读保留 Goal、obligation 和 action portfolio。随后原 Turn 的写回通过现有语义门禁。 写回与验收

对主干的风险 / Risks

在目标基线复现 4 条失败,在候选运行整个模块,32 项通过。Ruff、差异空白检查和 quick premerge 通过。两个本地后端使用合成 Goal,捕获分支显式设为 --context-delivery off。本次证据限于本地 CLI、原件和分段读取,正式安装 Host、渐进交付与远程检查独立验收。

我的整体评价 / Verdict

APPROVE。 修复恢复了原本未走到的回读与结算检查,并补足原摘要传播及损坏拒绝。生产代码没有改动。

English verdict: APPROVE at 1bd566c. The revised real-CLI test preserves complete capture binding and verifies staged reads, corruption refusal, digest carry-forward, and semantic writeback on the original Turn.

@loopx-agent
loopx-agent merged commit 7dfdd7a into main Nov 21, 2026
30 of 36 checks passed
@loopx-agent
loopx-agent deleted the codex/replan-staged-capture-contract-20261121 branch November 21, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant